-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do NOT land][experiment] use local_map to annotate TritonFusedRMSNorm #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
XilunWu
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 1e32ede62ada5204ddeb08259b7586d2acb73325 Pull Request resolved: #363
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
May 24, 2024
XilunWu
changed the title
use local_map to annotate TritonFusedRMSNorm
[do NOT land][experiment] use local_map to annotate TritonFusedRMSNorm
May 24, 2024
wanchaol
reviewed
May 24, 2024
…FusedRMSNorm" **Test Plan** unit test: `torchrun --nproc_per_node=4 --rdzv_backend c10d --rdzv_endpoint="localhost:0" test_fused_rms_norm.py` llama training test: `CONFIG_FILE=./train_configs/debug_model.toml NGPU=4 LOG_RANK=0,1,2,3 ./run_llama_train.sh` [ghstack-poisoned]
XilunWu
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 144f1e4526e490c76c3f50a25a6651e3985845e4 Pull Request resolved: #363
…FusedRMSNorm" **Test Plan** unit test: `torchrun --nproc_per_node=4 --rdzv_backend c10d --rdzv_endpoint="localhost:0" test_fused_rms_norm.py` llama training test: `CONFIG_FILE=./train_configs/debug_model.toml NGPU=4 LOG_RANK=0,1,2,3 ./run_llama_train.sh` [ghstack-poisoned]
XilunWu
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: a2c929d6de0c7ef8c561222e31de46e85c29dfd8 Pull Request resolved: #363
…FusedRMSNorm" **Test Plan** unit test: `torchrun --nproc_per_node=4 --rdzv_backend c10d --rdzv_endpoint="localhost:0" test_fused_rms_norm.py` llama training test: `CONFIG_FILE=./train_configs/debug_model.toml NGPU=4 LOG_RANK=0,1,2,3 ./run_llama_train.sh` [ghstack-poisoned]
XilunWu
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 9e02d5b23352c2a753d855b56f26abd10c10c332 Pull Request resolved: #363
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: 9e02d5b23352c2a753d855b56f26abd10c10c332 Pull Request resolved: #363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test Plan
unit test:
torchrun --nproc_per_node=4 --rdzv_backend c10d --rdzv_endpoint="localhost:0" test_fused_rms_norm.py
llama training test:
CONFIG_FILE=./train_configs/debug_model.toml NGPU=4 LOG_RANK=0,1,2,3 ./run_llama_train.sh